This repository has been archived by the owner on May 6, 2020. It is now read-only.
kill: Don't return an error if container state is 'created' #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR refers to opencontainers/runtime-spec#875 |
jodh-intel
reviewed
Jun 26, 2017
kill.go
Outdated
| if status.State.State != vc.StateRunning { | ||
| // container MUST be created or running | ||
| if status.State.State == vc.StateReady { | ||
| ccLog.Infof("Container state 'created', nothing to do") |
|
lgtm
|
|
lgtm |
Regarding a recent update of the OCI specification, we don't want to generate an error when 'kill' command is called on a container which has been created but not started. This is basically a no-op in our case. Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding a recent update of the OCI specification, we don't want to generate an error when 'kill' command is called on a container which has been created but not started.
This is basically a no-op in our case.